chore: enforce npm min-release-age dependency cooldown - #352
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
devin-ai-integration
Bot
force-pushed
the
devin/1785965627-npm-min-release-age
branch
from
August 7, 2026 13:56
40846aa to
334c004
Compare
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
tanderson-ld
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Supply chain hardening for legacy SDK repositories, mirroring js-core's yarn
npmMinimalAgeGate: 4320(3 days).Describe the solution you've provided
.npmrcwithmin-release-age=3(npm expresses this in days), so npm resolves only versions published more than 3 days ago. Unlike a Dependabot-level setting, this applies to every install — local development and CI alike.min-release-age-excludeexplicitly names the first-party packages this repo actually resolves (launchdarkly-js-sdk-common), so LaunchDarkly patches can be adopted immediately while third-party releases stay quarantined. Names are listed individually rather than pattern matched.npm@^11.17.0beforenpm install—min-release-age-excludelanded in npm 11.17.0, and the node 22 matrix entry bundles npm 10. The release workflow needs no change: node 24.x already bundles 11.17.0, so itsUpdate NPMstep is removed.Describe alternatives you've considered
Dependabot
cooldown— only governs Dependabot PRs, and these legacy repos aren't aiming to stay continuously updated.Additional context
Verified locally with npm 11.17.0: the gate blocks non-exempt packages, the exclude list is honored, and
npm installplus the test suite pass.Link to Devin session: https://app.devin.ai/sessions/566f0d951dfa4568b67ad0c6c1cfb7c1
Requested by: @joker23
Note
Overview
Introduces supply-chain hardening by adding
.npmrcwithmin-release-age=3, so npm only resolves package versions published more than three days ago for every install (local and CI).launchdarkly-js-sdk-commonis listed inmin-release-age-exclude[]so first-party LaunchDarkly packages can still be picked up immediately.CI matrix replaces Node 18 with
^24.19.0alongsidelatest. Release and manual publish workflows pin Node to^24.19.0(was24.x) and remove the globalnpm install -g npm@11.6.2step, relying on the Node-bundled npm that supports the new.npmrcoptions.Reviewed by Cursor Bugbot for commit abe9b56. Bugbot is set up for automated code reviews on this repo. Configure here.